[#RHQ-868] transforms expressions in response time URL transforms prop which contain an empty replacement string are not tokenized correctly

RHQ Project

transforms expressions in response time URL transforms prop which contain an empty replacement string are not tokenized correctly

Created: 19/Sep/08 08:47 PM Updated: 13/Oct/08 03:37 PM

Component/s:

Plugin Container

Affects Version/s:

1.0.1

Fix Version/s:

None

Time Tracking:

Original Estimate:

1 hour

Remaining Estimate:

1 hour

Time Spent:

Not Specified

Date of First Response:	22/Sep/08 05:55 AM
VCS Revision:	1,563

Description

« Hide

This is because ResponseTimeConfiguration.getTransforms() uses StringTokenizer, which does not consider empty strings to be tokens. For example "|foo||" returns only one token

"foo"

rather than two:

"foo" and ""

as we require. The code should be refactored to use String.split(), which does not have this limitation, instead.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Charles Crouch - 22/Sep/08 05:55 AM

Making this blocker for now.
Ian, is this fix required to solve case 219335? If so, then IMHO this needs to stay a blocker

[ Permlink | « Hide ]

Ian Springer - 22/Sep/08 01:04 PM

I'm not sure yet. If it turns out the transforms expression is the cause, it might provide a workaround by providing an alternative expression for chopping off query strings. I need to figure out whether it's the excludes or the transforms or the combination of the two that are causing her problem. I failed to reproduce it on Friday. I was using the same excludes and the transforms that I recommended to her without any issues. I was using Tomcat, not Apache, though, which I don't think would make a difference, but I am going to try with Apache today to be sure.

[ Permlink | « Hide ]

Greg Hinkle - 06/Oct/08 04:12 PM

Not that critical afterall, will target fix for 1.2 as ips has it implemented already.