
|
If you were logged in you would be able to see more operations.
|
|
|
RHQ Project
Created: 21/May/08 05:46 AM
Updated: 22/Jul/08 12:57 PM
|
|
| Component/s: |
None
|
| Affects Version/s: |
0.1
|
| Fix Version/s: |
1.1
|
|
| Resolution Date: |
19/Jul/08 09:35 PM
|
| Date of First Response: |
19/Jul/08 09:35 PM
|
| VCS Revision: |
1,122
|
|
Run the test with a debugger stopping on NPEs
e.g.
org.rhq.enterprise.server.resource.group.test.RecursiveResourceGroupTest.testImplicitGroupMembershipFromInventoryUpdate():
Resource nodeOne = ResourceTreeHelper.findNode(fullTree, "1");
resourceGroupManager
.addResourcesToGroup(subject, recursiveGroup.getId(), new Integer[] { nodeOne.getId() });
If nodeOne is null, nodeOne.getId() yields a NPE which got silently swallowed later, so the Test never fails.
ResourceTreeHelper:
public static List<Resource> getSubtree(Resource resource) {
List<Resource> subtree = new ArrayList<Resource>();
List<Resource> toBeSearched = new LinkedList<Resource>();
toBeSearched.add(resource);
while (toBeSearched.size() > 0) {
Resource next = toBeSearched.get(0);
subtree.add(next);
toBeSearched.addAll(next.getChildResources());
}
next is null in the testsuite called from org.rhq.enterprise.server.resource.group.test.RecursiveResourceGroupTest.testImplicitGroupMembershipFromComplexGroupUpdates()
|
|
Description
|
Run the test with a debugger stopping on NPEs
e.g.
org.rhq.enterprise.server.resource.group.test.RecursiveResourceGroupTest.testImplicitGroupMembershipFromInventoryUpdate():
Resource nodeOne = ResourceTreeHelper.findNode(fullTree, "1");
resourceGroupManager
.addResourcesToGroup(subject, recursiveGroup.getId(), new Integer[] { nodeOne.getId() });
If nodeOne is null, nodeOne.getId() yields a NPE which got silently swallowed later, so the Test never fails.
ResourceTreeHelper:
public static List<Resource> getSubtree(Resource resource) {
List<Resource> subtree = new ArrayList<Resource>();
List<Resource> toBeSearched = new LinkedList<Resource>();
toBeSearched.add(resource);
while (toBeSearched.size() > 0) {
Resource next = toBeSearched.get(0);
subtree.add(next);
toBeSearched.addAll(next.getChildResources());
}
next is null in the testsuite called from org.rhq.enterprise.server.resource.group.test.RecursiveResourceGroupTest.testImplicitGroupMembershipFromComplexGroupUpdates() |
Show » |
|
Heiko, findBugs? ; )