History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: RHQ-445
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Joseph Marques
Reporter: Heiko W. Rupp
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
RHQ Project

Ops scheduling shows a stack trace on invalid input

Created: 06/May/08 07:51 AM   Updated: 18/Dec/08 08:31 AM
Component/s: FX - Operations, Core UI
Affects Version/s: 0.1
Fix Version/s: 1.2

Time Tracking:
Not Specified

Resolution Date: 14/Dec/08 07:58 PM
Date of First Response: 07/May/08 03:08 AM
Tester: Jeff Weiss
VCS Revision: 2,385


 Description  « Hide
When for a scheduled recurring ops, the end time is before the start time,

the following error is shown. The error in its semantics is correct, but it should be nicely displayed in the schedule page instead of a exception page.


javax.servlet.ServletException: #{ResourceOperationScheduleUIBean.schedule}: java.lang.IllegalArgumentException: End time cannot be before start time
javax.faces.webapp.FacesServlet.service(FacesServlet.java:277)
org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:141)
org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:281)
org.rhq.enterprise.gui.legacy.AuthenticationFilter.doFilter(AuthenticationFilter.java:128)
org.rhq.enterprise.gui.common.upload.MultipartFilter.doFilter(MultipartFilter.java:63)
org.rhq.helpers.rtfilter.filter.RtFilter.doFilter(RtFilter.java:112)
org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
root cause




 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Joseph Marques - 07/May/08 03:08 AM
yeah, this is messy. should be quick and easy to clean up.

Joseph Marques - 08/Sep/08 04:03 AM
rev1384 - make sure to catch all potential errors while scheduling an operation, setting an appropriate message in the faces context, and returning to the schedule page;

Corey Welton - 09/Sep/08 09:26 AM
> rev1384 - make sure to catch all potential errors while scheduling an operation, setting an appropriate message in the faces context,
> and returning to the schedule page;

Per statement aboive, is this bug to capture all instances of similar breakage in scheduling? If so, this fails QA. The scenario outline above works correctly. However, entering invalid data in the "Recur every:" field results in tracebacks as well.

For example, enter the following string in the "Recur Every" field.

09/09/2008 9:15:00

End result is an exception:
javax.servlet.ServletException: Required request parameter 'repeatInterval' is missing.
javax.faces.webapp.FacesServlet.service(FacesServlet.java:277)
org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:147)
org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:276)
org.ajax4jsf.Filter.doFilter(Filter.java:175)
org.rhq.enterprise.gui.legacy.AuthenticationFilter.doFilter(AuthenticationFilter.java:128)
org.rhq.enterprise.gui.common.upload.MultipartFilter.doFilter(MultipartFilter.java:63)
org.rhq.helpers.rtfilter.filter.RtFilter.doFilter(RtFilter.java:113)
org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)

[....]


If we are limiting scope of this bug solely to the behaviour as reported initially, I will verify this and create a new bug for the above scenario. However, given that we have attempted to "make sure to catch all potential errors while scheduling an operation", this may fall under the same category. Please advise.

Joseph Marques - 14/Dec/08 07:58 PM
rev2385 - scheduling an operation no longer shows a stack trace on invalid input - all exceptions are caught and an error message is displayed instead;
"Recur Every" can never be an invalid value anymore, updated our custom trigger JSF component to leverage the InputNumberSpinner from the richfaces component library;

Jeff Weiss - 18/Dec/08 08:31 AM
I scheduled an op with the end time for the repeats to be before the start time. I got a nice message saying that the end time can't be before the start time. rev2424, windows/oracle