|
|
|
[
Permlink
| « Hide
]
Joseph Marques - 05/Nov/08 10:22 AM
maybe this is feature creep, but why have global configurations at all? why not make this configurable at the resource-level, resourceType-level, and/or resourceGroup-level?
joe - something to discuss for a new feature in future version. Definitely feature creep.
For now, this JIRA is to document the need to possibly reduce the global time frame from a default of 31 days to 14 or 7 days. A global config at least gives a default, even if you add granularity. An interesting idea although it may border on too much flexibility. I'd suggest waiting for customer feedback, if only for simplicity in the purge job.
I'm not sure generating events at that level is really worthwhile for a real customer. I'm still skeptical about event generation that isn't tied to alert firing. And that would imply that event's usefulness degrades fairly quickly. Seeing events on the timeline is interesting, maybe, but a month may be more than needed. So, I guess I'd favor a shorter, perhaps 14 day purge. Or, a limit on the number of events, as opposed to a date range. this is something I want to discuss for 1.2. If we do want to change the defaults, should be a very fast fix.
FWIW, EventReport has this code in it to attempt to throttle events:
private static final int MAX_EVENTS_PER_SOURCE = 1000; ... if (eventSet.size() < MAX_EVENTS_PER_SOURCE) eventSet.add(event); else if (eventSet.size() == MAX_EVENTS_PER_SOURCE) LOG.warn(eventSource + " contains the maximum allowed Events per source (" + MAX_EVENTS_PER_SOURCE + ") - no more Events from this source will be added to this report."); |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||