History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: RHQ-1000
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: John Mazzitelli
Reporter: John Mazzitelli
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
RHQ Project

NPE in UI code when executing operation

Created: 20/Oct/08 07:43 PM   Updated: 10/Dec/08 01:50 PM
Component/s: Core UI
Affects Version/s: 1.2
Fix Version/s: 1.2

Time Tracking:
Not Specified

Resolution Date: 21/Oct/08 08:36 AM
Date of First Response: 10/Dec/08 01:50 PM
Tester: Corey Welton
VCS Revision: 1,816


 Description  « Hide
Try to execute an operation and you get this:

You get a 500 error with this stack in browser:

javax.servlet.ServletException
javax.faces.webapp.FacesServlet.service(FacesServlet.java:277) org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:147)
org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:276)
org.ajax4jsf.Filter.doFilter(Filter.java:175) org.rhq.enterprise.gui.legacy.AuthenticationFilter.doFilter(AuthenticationFilter.java:128)
org.rhq.enterprise.gui.common.upload.MultipartFilter.doFilter(MultipartFilter.java:63) org.rhq.helpers.rtfilter.filter.RtFilter.doFilter(RtFilter.java:113) org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)

root cause

java.lang.NullPointerException org.rhq.core.gui.util.FacesComponentUtility.detachComponent(FacesComponentUtility.java:474)
org.rhq.core.gui.configuration.ConfigRenderer.decode(ConfigRenderer.java:99) javax.faces.component.UIComponentBase.decode(UIComponentBase.java:777)
javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1019)
javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1014)
javax.faces.component.UIForm.processDecodes(UIForm.java:209)
org.ajax4jsf.component.AjaxViewRoot$1.invokeContextCallback(AjaxViewRoot.java:387)
org.ajax4jsf.component.AjaxViewRoot.processPhase(AjaxViewRoot.java:234)
org.ajax4jsf.component.AjaxViewRoot.processDecodes(AjaxViewRoot.java:404)
com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestValuesPhase.java:78)
com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100)
com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118)
javax.faces.webapp.FacesServlet.service(FacesServlet.java:265)
org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:147)
org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:276)
org.ajax4jsf.Filter.doFilter(Filter.java:175)
org.rhq.enterprise.gui.legacy.AuthenticationFilter.doFilter(AuthenticationFilter.java:128)
org.rhq.enterprise.gui.common.upload.MultipartFilter.doFilter(MultipartFilter.java:63)
org.rhq.helpers.rtfilter.filter.RtFilter.doFilter(RtFilter.java:113)
org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)

I think this was caused by rev1805 for RHQ-996 and RHQ-891

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
John Mazzitelli - 20/Oct/08 07:45 PM
ConfigRenderer had this added to it in svn rev1805:

   UIComponent initInputsJavaScriptComponent = config.findComponent(INIT_INPUTS_JAVA_SCRIPT_COMPONENT_ID);
   FacesComponentUtility.detachComponent(initInputsJavaScriptComponent);

I will wrap it in a null-check:

   UIComponent initInputsJavaScriptComponent = config.findComponent(INIT_INPUTS_JAVA_SCRIPT_COMPONENT_ID);
   if (initInputsJavaScriptComponent != null) {
      FacesComponentUtility.detachComponent(initInputsJavaScriptComponent);
   }

John Mazzitelli - 20/Oct/08 07:48 PM
this has been fixed - someone needs to triage and close as fixed this issue.

svn rev 1816

Corey Welton - 10/Dec/08 01:50 PM
QA Verified, ops aren't causing any NPEs in the latest qa drop.